Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add publish workflow #41

Merged
merged 3 commits into from
May 31, 2023
Merged

Add publish workflow #41

merged 3 commits into from
May 31, 2023

Conversation

jcbhmr
Copy link
Collaborator

@jcbhmr jcbhmr commented May 30, 2023

ref #40

This PR would...

  • Add a workflow that runs on each published release (and pre-release) to publish that current state of the repo to npm using npm publish
  1. Make sure that when you create releases you have already bumped the version in package.json!
  2. Make sure you add an NPM_TOKEN secret with publish permissions!

It might also be worth considering using https://github.com/github/gitignore/blob/main/Node.gitignore and generating dist/ in a prepack hook in CI so that the dist JS isn't stored and versioned in Git. 🤔

@mesqueeb mesqueeb changed the base branch from production to dev May 31, 2023 01:04
@jcbhmr jcbhmr requested a review from mesqueeb May 31, 2023 04:59
@jcbhmr jcbhmr self-assigned this May 31, 2023
@jcbhmr jcbhmr mentioned this pull request May 31, 2023
Open
8 tasks
@mesqueeb mesqueeb merged commit b22419c into mesqueeb:dev May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesqueeb mesqueeb Awaiting requested review from mesqueeb

Assignees

@jcbhmr jcbhmr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcbhmr @mesqueeb