Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some encoding fixes #61

Merged
merged 4 commits into from
Jun 28, 2021
Merged

Conversation

mehmetminanc
Copy link

Summary

  • Fixes encoding issue when JSON is serialized.
  • The current code ASCII encodes Unicode characters in UTF-8 message. Which is suboptimal.
  • Simplifies travis flow, adds requirements file.
  • The test cases looks funky because of the way json lib handles encoding.

Description

I was actually diving deep into some issue where the message Pijamalı hasta yağız şoföre çabucak güvendi loses its unicode characters, but noticed that the encoding was off in the request sent to the API, through Fiddler. This is not the source of the problem but I think a minor improvement is due.

Testing

  • Unit tests.
  • Local tests with personal account, requests routed to monitoring proxy.
    • Executed with Python 2.7 and 3.8.
    • Using Turkish and Japanese text.

max-inanc and others added 4 commits September 11, 2020 16:19
* Simplifies travis flow, adds requirements file.
* Triple quotes json test fixtures for better readability.
* Removes ignores from pycodestyle.
@marcelcorso marcelcorso merged commit 5f4d9ae into messagebird:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants