-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema upgrade: 1.3.0 #310
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The updates on the DEX's at least look good to me. |
Works for us! |
melotik
reviewed
Jun 13, 2022
dex amm schema changes look good |
0xbe1
reviewed
Jun 14, 2022
0xbe1
pushed a commit
to 0xbe1/subgraphs
that referenced
this pull request
Jun 14, 2022
* Added pool-level revenue * Fix markdown formatting issue in comments * Updated constants * Schema changes for Bancor v3 * Address code review comments
tnkrxyz
pushed a commit
to tnkrxyz/subgraphs
that referenced
this pull request
Jun 23, 2022
* Added pool-level revenue * Fix markdown formatting issue in comments * Updated constants * Schema changes for Bancor v3 * Address code review comments
0xbe1
pushed a commit
to 0xbe1/subgraphs
that referenced
this pull request
Jun 27, 2022
* Added pool-level revenue * Fix markdown formatting issue in comments * Updated constants * Schema changes for Bancor v3 * Address code review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common
DEXes
isSingleSided
for single-sided pools. Single-sided pools should be able to reuse/adopt most if not all of the existing fields with minor adaptation. These should be handled on a per protocol basis.Lending
fixed_term
tofixed
inInterestRateType
entity to be more precise.