Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for musl linux distros #9

Merged
merged 3 commits into from
May 22, 2024
Merged

Add support for musl linux distros #9

merged 3 commits into from
May 22, 2024

Conversation

kfdm
Copy link
Contributor

@kfdm kfdm commented May 22, 2024

This adapts the workflow configuration from [1] and applies it here, so that we can build promql-parser packages for distrobutions that use musl.

[1] https://github.com/messense/nh3/blob/b5074b186b813313b258a7c97871bb2d9fc0eaa7/.github/workflows/CI.yml

Fixes #7

kfdm and others added 2 commits May 22, 2024 09:34
It's useful to cancel in progress builds when we push a new build.
This adapts the workflow configuration from [1] and applies it here, so
that we can build promql-parser packages for distrobutions that use musl.

[1] https://github.com/messense/nh3/blob/b5074b186b813313b258a7c97871bb2d9fc0eaa7/.github/workflows/CI.yml
@kfdm
Copy link
Contributor Author

kfdm commented May 22, 2024

I'm still trying to test on my fork, though I have not yet gotten x86_64-unknown-linux-musl to build correctly. Posting here for early feedback.

kfdm#1

.github/workflows/CI.yml Outdated Show resolved Hide resolved
Co-authored-by: messense <messense@icloud.com>
@kfdm
Copy link
Contributor Author

kfdm commented May 22, 2024

Thank you for the pointer! Looks like that fixed it in my fork so I'll commit your suggestion and let it run again.

@messense messense merged commit 56e0365 into messense:main May 22, 2024
8 checks passed
@messense
Copy link
Owner

Will push a new release after work.

@kfdm
Copy link
Contributor Author

kfdm commented May 22, 2024

No rush! Thanks again for the python bindings and guiding me through adding support 🙇

@messense
Copy link
Owner

Released in v0.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build for Alpine linux?
2 participants