fixed alpaca dataset evalset length and make sure len(eval_loader)>0 #540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixed alpaca dataset evalset length by using 5% of the dataset as evalset so the len(eval_dataloader) >0, that means at least one batch can be loaded by dataloader. Also added a check to make sure len(eval_dataloader)>0 when run_validation=True, otherwise raise error and stop training.
This problem is raised by issue 520
Feature/Issue validation/testing
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Before submitting
Pull Request section?
to it if that's the case.
Thanks for contributing 🎉!