Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Groq/Llama3 recipes (cookbook and command line examples) #553

Merged
merged 9 commits into from
Jun 17, 2024

Conversation

dloman118
Copy link
Collaborator

@dloman118 dloman118 commented Jun 5, 2024

What does this PR do?

Feature/Issue validation/testing

These cookbooks can be run as jupyter notebooks provided that GROQ_API_KEY is set as an environment variable (Groq API Keys can be curated here: https://console.groq.com/keys

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Thanks for contributing 🎉!

6/6 update: I am failing on lint/spellcheck tests but I don't believe that I should be:

  • https://console.groq.com/keys is a valid address (you do need to be logged in)
  • Words such as 'Groq', 'GroqCloud', 'DuckDB' and 'Replit' are valid in the context of my README files

@HamidShojanazeri
Copy link
Contributor

@dloman118 thanks for the PR! can we pls merge all the Groq examples under Groq folder? recipes/ /llama_api_providers/Groq that would help with a cleaner outline.

@HamidShojanazeri
Copy link
Contributor

Also appreciate if we can fix the broken link errors.

@HamidShojanazeri HamidShojanazeri self-assigned this Jun 10, 2024
@dloman118
Copy link
Collaborator Author

@HamidShojanazeri thanks for reviewing! I made a new commit to move all of the Groq examples to a new Groq folder (I left llama3_cookbook_groq.ipynb separate within that folder because it was not authored by us, but could move it with the other cookbook posts if that is preferable). I had removed one broken link, but https://console.groq.com/keys is being flagged incorrectly as a broken link by the tests, perhaps because it requires login to access.

@HamidShojanazeri
Copy link
Contributor

thanks @dloman118 for the updates! can you pls use <!-- markdown-link-check-disable --> and <!-- markdown-link-check-enable --> to bypass the error.

@dloman118
Copy link
Collaborator Author

thanks @dloman118 for the updates! can you pls use <!-- markdown-link-check-disable --> and <!-- markdown-link-check-enable --> to bypass the error.

Thanks @HamidShojanazeri we should be all set with the broken links now. We are still failing the Spellcheck test with valid words like the following, are there additional strategies to ignore these in the tests or is this ok?

DataFrame
DuckDB
Groq
GroqCloud
Replit
Teslas
duckdb
teslas

@HamidShojanazeri HamidShojanazeri self-requested a review June 17, 2024 15:05
Copy link
Contributor

@HamidShojanazeri HamidShojanazeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, @dloman118! LGTM

@HamidShojanazeri HamidShojanazeri merged commit a32e919 into main Jun 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants