Port of DLAI LlamaIndex Agent short course lessons 2-4 to use Llama 3 #594
Conversation
...i_agentic_rag/Building_Agentic_RAG_with_Llamaindex_L3_Building_an_Agent_Reasoning_Loop.ipynb
Outdated
Show resolved
Hide resolved
...ai_agentic_rag/Building_Agentic_RAG_with_Llamaindex_L4_Building_a_Multi-Document_Agent.ipynb
Show resolved
Hide resolved
|
|
||
| 3. [Building Agentic RAG with Llamaindex L3 Building an Agent Reasoning Loop](Building_Agentic_RAG_with_Llamaindex_L3_Building_an_Agent_Reasoning_Loop.ipynb) | ||
|
|
||
| 3. [Building Agentic RAG with Llamaindex L4 Building a Multi-Document Agent](Building_Agentic_RAG_with_Llamaindex_L4_Building_a_Multi-Document_Agent.ipynb) |
There was a problem hiding this comment.
| 3. [Building Agentic RAG with Llamaindex L4 Building a Multi-Document Agent](Building_Agentic_RAG_with_Llamaindex_L4_Building_a_Multi-Document_Agent.ipynb) | |
| 4. [Building Agentic RAG with Llamaindex L4 Building a Multi-Document Agent](Building_Agentic_RAG_with_Llamaindex_L4_Building_a_Multi-Document_Agent.ipynb) |
There was a problem hiding this comment.
Let me add a note in the README about the first lesson to avoid possible confusion.
|
Thanks Jeff for preparing these! Do you think we can add a few lines for each notebook on what the goal of the notebook is and what are the high-level steps we are following in the notebook to achieve that use case? |
| "#llm = Fireworks(model=\"accounts/fireworks/models/llama-v3-8b-instruct\", temperature=0)\n", | ||
| "llm = Fireworks(model=\"accounts/fireworks/models/llama-v3-70b-instruct\", temperature=0)\n", | ||
| "\n", | ||
| "# a quick sanity test\n", |
There was a problem hiding this comment.
Should we remove commented out snippets?
There was a problem hiding this comment.
I think it's ok to keep them since there's some info in the comments "Llama 3 8b on Fireworks.ai also works in some cases, but 70b works better overall" and the actual 8b model name in case someone wonders.
Thanks @fbnav for the detailed review. Good idea! I added lesson summary in each notebook and the folder README. |
What does this PR do?
Fixes # (issue)
Feature/Issue validation/testing
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Logs for Test A
Test B
Logs for Test B
Before submitting
Pull Request section?
to it if that's the case.
Thanks for contributing 🎉!