Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kotlin docs #568

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Add kotlin docs #568

merged 2 commits into from
Dec 6, 2024

Conversation

Riandy
Copy link
Contributor

@Riandy Riandy commented Dec 5, 2024

What does this PR do?

In short, provide a summary of what this PR does and why. Usually, the relevant context should be present in a linked issue.

Docs update for Kotlin SDK release

Test Plan

Please describe:

  • tests you ran to verify your changes with result summaries.
  • provide instructions so it can be reproduced.

Sources

Please link relevant resources if necessary.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Ran pre-commit to handle lint / formatting issues.
  • Read the contributor guideline,
    Pull Request section?
  • Updated relevant documentation.
  • Wrote necessary unit or integration tests.

@Riandy Riandy requested a review from cmodi-meta December 5, 2024 02:59
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 5, 2024
@Riandy
Copy link
Contributor Author

Riandy commented Dec 5, 2024

Note: Feel free to review the PR and suggest changes, but don't merge it yet. We will merge this at the same time when we release the Kotlin SDK

@cmodi-meta
Copy link

@Riandy - Note the readme will need to be updated as well to replace the "TODOs"

@yanxi0830
Copy link
Contributor

https://github.com/meta-llama/llama-stack/blob/main/CONTRIBUTING.md#building-the-documentation -- you could follow this instructions here to preview the documentation, and attach a screenshot in the test plan.

@Riandy
Copy link
Contributor Author

Riandy commented Dec 6, 2024

Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeehaw!

@ashwinb ashwinb merged commit 09fbf2d into main Dec 6, 2024
2 checks passed
@ashwinb ashwinb deleted the kotlin-docs branch December 6, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants