Make LlamaStackLibraryClient work correctly #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinb
requested review from
yanxi0830,
hardikjshah,
dltn and
raghotham
as code owners
facebook-github-bot
added
the
CLA Signed
ashwinb
commented
Dec 7, 2024
| T = TypeVar("T") | ||
|
|
||
|
|
||
| def stream_across_asyncio_run_boundary( |
There was a problem hiding this comment.
this is a most crucial part of this PR. without this you cannot make the "non-async" generators (which is a necessary mode for our client-sdk) work properly. you must be able to do for chunk in inference.chat_completion() since that's what synchronous generators are about. to bridge a sync generator to the async generators we have in our server-side code we need to intermediate via a thread pool.
raghotham
approved these changes
Dec 7, 2024
yanxi0830
reviewed
Dec 9, 2024
|
|
||
|
|
||
| def main(config_path: str): | ||
| client = LlamaStackAsLibraryClient(config_path) |
There was a problem hiding this comment.
https://llama-stack.readthedocs.io/en/latest/distributions/importing_as_library.html
does this reference to LlamaStackDirectClient also needs to be updated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
LlamaStackLibraryClientIn many ways, this PR makes things finally "work"
Test Plan
See a
library_client_test.pyI added. This isn't really quite a test yet but it demonstrates that this mode now works. Here's the invocation and the response: