Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop rustc-serialize dependency #2

Closed
dtolnay opened this issue Apr 23, 2017 · 4 comments
Closed

Drop rustc-serialize dependency #2

dtolnay opened this issue Apr 23, 2017 · 4 comments

Comments

@dtolnay
Copy link

dtolnay commented Apr 23, 2017

It has been deprecated: announcement.

@cardoe
Copy link
Collaborator

cardoe commented Apr 23, 2017

I'd honestly love to. I've stopped using it and switched to Serde for most of my projects already. The reason for this is that I use Cargo to parse the args and the latest Cargo version, 0.17 requires struct that defines the options to derive RustcDecodable.

@cardoe
Copy link
Collaborator

cardoe commented Apr 23, 2017

Here's the current error when I attempt to use Serde.

let result = cargo::call_main_without_stdin(real_main, &config, USAGE, &args, false);
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `rustc_serialize::serialize::Decodable` is not implemented for `Options`

@dtolnay
Copy link
Author

dtolnay commented Apr 23, 2017

Cool, I filed rust-lang/cargo#3944 to track this on Cargo's end.

@cardoe
Copy link
Collaborator

cardoe commented Apr 23, 2017

Thanks. I might drop using that entry point and switch to clap to parse the args and then I can drop rustc-serialize.

cardoe added a commit that referenced this issue Oct 30, 2017
Upgraded from cargo 0.19 to 0.21. This allows us to drop rustc-serialize
as a dependency and only use serde, fixing #2.
@cardoe cardoe closed this as completed in 057f300 Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants