Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cargo and git2 to latest version #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kkettinger
Copy link

Updating cargo and git2 to the latest version fixes issue #69.

@hardliner66
Copy link

I'm currently blocked on this exact problem. Would be nice if we could get this merged.

@jaskij
Copy link

jaskij commented Aug 28, 2023

You need to update Cargo.lock as well, otherwise cargo install --locked won't work.

While you're at it, bumping up to cargo 0.73 and itertools 0.11 might be a good idea.

@kkettinger
Copy link
Author

Sorry for the late response. I could update the dependency of cargo to 0.74.0, newer versions break the build (same with git2 0.18.2). I've also updated itertools to 0.11. Please check and approve.

@IniterWorker
Copy link

IniterWorker commented Apr 24, 2024

One thought: should we confine ourselves to the meta-rust MSRV?
-Since the latest Cargo version corresponds to +/- the latest MSRV, certain features might not function properly when using the bitbake-generated recipe.

EDITED: This PR follows the changes outlined in https://github.com/meta-rust/cargo-bitbake/pull/61/files. @kkettinger, according to the dependencies requirements, we should update the MSRV in this PR too.

@jaskij
Copy link

jaskij commented Apr 24, 2024

Isn't the current meta-rust at 1.75 though? I have started work on updating to latest possible dependencies, and it does seem to work, although the MSRV is 1.75.

Wasn't able to test extensively yet, but the changes were minimal. At least it compiles and generates recipes, but I wasn't able to check if the generated recipes work. I'll have a PR up shortly.

I'm not familiar with what other's working environments are, but for me the version of Rust installed on the development machine is decoupled from the version in our image, so having cargo-bitbake require 1.75 is a non-issue.

@jaskij
Copy link

jaskij commented Apr 24, 2024

Created #75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants