Merge pull request #3075 from metabrainz/artist-search-disambiguation

LB-1707: Add sort name and disambiguation in artist search pages
metabrainz · Dec 13, 2024 · 7e5991b · 7e5991b
2 parents 62b8a87 + c57a654
commit 7e5991b
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/frontend/js/src/search/ArtistSearch.tsx b/frontend/js/src/search/ArtistSearch.tsx
@@ -105,7 +105,17 @@ export default function ArtistSearch(props: ArtistSearchProps) {
               <tr key={artist?.id}>
                 <td>{(currPageNo - 1) * ARTIST_COUNT_PER_PAGE + index + 1}</td>
                 <td>
-                  <Link to={`/artist/${artist?.id}/`}>{artist?.name}</Link>
+                  <Link
+                    to={`/artist/${artist?.id}/`}
+                    title={`(${artist["sort-name"]}${
+                      artist?.disambiguation ? `, ${artist.disambiguation}` : ""
+                    })`}
+                  >
+                    {artist?.name}
+                  </Link>
+                  {artist?.disambiguation && (
+                    <small>&nbsp;({artist.disambiguation})</small>
+                  )}
                 </td>
                 <td>{artist?.type}</td>
                 <td>{_.capitalize(artist?.gender)}</td>

diff --git a/frontend/js/src/search/types.d.ts b/frontend/js/src/search/types.d.ts
@@ -42,6 +42,17 @@ type TrackTypeSearchResult = {
   }[];
 };
 
+type Alias = {
+  "sort-name": string;
+  "type-id": string;
+  name: string;
+  locale: string | null;
+  type: string;
+  primary: boolean | null;
+  "begin-date": number | null;
+  "end-date": number | null;
+};
+
 type ArtistTypeSearchResult = {
   count: number;
   offset: number;
@@ -51,9 +62,12 @@ type ArtistTypeSearchResult = {
     type?: string;
     country?: string;
     gender?: string;
+    "sort-name"?: string;
+    disambiguation?: string;
     area?: {
       name: string;
     };
+    aliases?: Alias[];
   }[];
 };