-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Make redis, postgres and rabbitmq hosts configurable via env variables #264
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing to this repository.
The general idea is great.
I pushed a few amending commits to replace the last occurrences of db
and redis
in build files.
What is still missing:
depends_on
still refer to service names in compose files; See:git grep -Pw -- '- (db|mq|redis)' '**yml'
- Many occurences of
db
,mq
andredis
remain in helper scripts under the directoryadmin/
; See:git grep -Pw 'db|mq|redis' admin/
- New variables have to be documented in
README.md
For 1. I have no idea how to handle it or if it even matters when using Kubernetes.
For 2. & 3. I can do if needed whenever I have time but that isn’t my current priority.
Thanks for the feedback !
Working on the 2. now. |
For 2, I read those scripts (I just checked the one in the output of tldr; I don't think any of them has to be changed as they are not included in the Docker image and not meant to be executed from inside any of the containers. |
Even though some helper scripts won’t work anymore, these are not strictly needed. One can either adapt these or run commands manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your contribution!
I improved the documentation you provided (for 3.) by mentioning that:
- the unused services will still be running (for 1.),
- some (dispensable) helper scripts will no longer work (for 2.),
- (potentially) some actions can be needed when switching to a new back-end server.
I am trying to deploy our musicbrainz mirror in kubernetes using an external DB.
This PR updates the config files to read the db,redis,mq hosts from env variables and default them to the current value