MBS-12552: Move Entity role Linkable to Relatable (#2717)

Linkable is used in entityHref.js only and in a way broader meaning, whereas Relatable is used in a lot of files (including the very central Constants.pm and entities.mjs) and in the same meaning as in this role: “that can have relationships”.
metabrainz · Nov 8, 2022 · f7d45e8 · f7d45e8
1 parent 7a73902
commit f7d45e8
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/lib/MusicBrainz/Server/Entity/CoreEntity.pm b/lib/MusicBrainz/Server/Entity/CoreEntity.pm
@@ -6,7 +6,7 @@ extends 'MusicBrainz::Server::Entity';
 with 'MusicBrainz::Server::Entity::Role::Editable';
 with 'MusicBrainz::Server::Entity::Role::GID';
 with 'MusicBrainz::Server::Entity::Role::LastUpdate';
-with 'MusicBrainz::Server::Entity::Role::Linkable';
+with 'MusicBrainz::Server::Entity::Role::Relatable';
 with 'MusicBrainz::Server::Entity::Role::Name';
 
 __PACKAGE__->meta->make_immutable;

diff --git a/lib/MusicBrainz/Server/Entity/Relationship.pm b/lib/MusicBrainz/Server/Entity/Relationship.pm
@@ -42,7 +42,7 @@ has 'entity0_id' => (
 
 has 'entity0' => (
     is => 'rw',
-    isa => 'Linkable',
+    isa => 'Relatable',
 );
 
 has 'entity0_credit' => (
@@ -57,7 +57,7 @@ has 'entity1_id' => (
 
 has 'entity1' => (
     is => 'rw',
-    isa => 'Linkable',
+    isa => 'Relatable',
 );
 
 has 'entity1_credit' => (
@@ -130,7 +130,7 @@ sub can_manually_reorder {
 
 has source => (
     is => 'rw',
-    isa => 'Linkable',
+    isa => 'Relatable',
 );
 
 has source_type => (
@@ -145,7 +145,7 @@ has source_credit => (
 
 has target => (
     is => 'rw',
-    isa => 'Linkable',
+    isa => 'Relatable',
 );
 
 has target_type => (

diff --git a/...usicBrainz/Server/Entity/Role/Linkable.pm → ...sicBrainz/Server/Entity/Role/Relatable.pm b/...usicBrainz/Server/Entity/Role/Linkable.pm → ...sicBrainz/Server/Entity/Role/Relatable.pm
@@ -1,4 +1,4 @@
-package MusicBrainz::Server::Entity::Role::Linkable;
+package MusicBrainz::Server::Entity::Role::Relatable;
 use Moose::Role;
 
 use List::AllUtils qw( partition_by sort_by );
@@ -132,7 +132,7 @@ around TO_JSON => sub {
 
 =head1 NAME
 
-MusicBrainz::Server::Entity::Role::Linkable
+MusicBrainz::Server::Entity::Role::Relatable
 
 =head1 ATTRIBUTES
 

diff --git a/lib/MusicBrainz/Server/Entity/Types.pm b/lib/MusicBrainz/Server/Entity/Types.pm
@@ -36,8 +36,8 @@ subtype 'Edit'
 subtype 'Entity'
     => as class_type 'MusicBrainz::Server::Entity';
 
-subtype 'Linkable'
-    => as role_type 'MusicBrainz::Server::Entity::Role::Linkable';
+subtype 'Relatable'
+    => as role_type 'MusicBrainz::Server::Entity::Role::Relatable';
 
 1;