MBS-12622: Show if URL / URL relationship has pending edits in links editor #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brainzbot, retest this please |
reosarevok
force-pushed
the
MBS-12622
branch
2 times, most recently
from
0a8d644 to
ec80cb1
Compare
reosarevok
force-pushed
the
MBS-12622
branch
3 times, most recently
from
eb7a008 to
aba5623
Compare
reosarevok
force-pushed
the
MBS-12622
branch
from
aba5623 to
aefc32e
Compare
mwiencek
approved these changes
Sep 13, 2023
| import type { | ||
| RelationshipStateT, | ||
| } from '../types.js'; | ||
|
|
||
|
|
There was a problem hiding this comment.
is adding two newlines after the all the imports something you want to enforce with eslint? I don't mind either way but noticed you tend to add it
There was a problem hiding this comment.
Huh. I'm not sure I even do it consciously - I don't know if it's better and I might even rather enforce just one and stop me from doing this :D
There was a problem hiding this comment.
I removed the extra lines here - seems import-js/eslint-plugin-import#1933 has been there for three years but is unmerged, so there's currently no exact option. Not sure if there's something we can do but I commented anyway.
We now show a special icon on the (non-URL) relationship editor if a relationship that can be changed has (previous) pending edits. This adds the same icon to the URL editor, where nothing was being shown currently. This should help avoid unnecessary URL removals when someone is already setting it as ended, for example. The externalLinks code does slightly odd things to entity/relationship data to put them into state, so flow typing here is pretty messy - unsure if it can be improved without a proper refactoring of the externalLinks component though.
If a URL is being edited, we should indicate it in the links editor. This way it is possible to find out that, say, the URL you are adding or changing the relationship for is actually going to change soon, otherwise making your changes have unexpected consequences.
reosarevok
force-pushed
the
MBS-12622
branch
from
aefc32e to
796a3d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-12622
Problem
We now show a small icon when a relationship has pending edits in the relationship editor (see #2858), but nothing is shown in the link editor if a URL relationship has pending edits. We should probably show an icon there (by each specific relationship under the link).
We don't show at the moment if the entity itself in the relationship has open edits, but we should probably still show something for URLs when the URL itself is being edited, at least, since that can sneakily make any relationships entered/changed wrong as soon as the edit applies.
Solution
This implements a tooltip in the same way as #2858. For URL relationships it literally reuses the code (I moved it to a reusable component). For pending URL edits it points to
/url/mbid/open_edits, which is the best I could think of (I don't think we have a trivial way to see only the kinds of edits which triggerurl.editsPending).I put this on top of #2901 now since that adds better icons we can reuse here rather than the warning icon.
Testing
Manually, by making open/votable changes to both a URL string and the dates on a URL relationship and making sure the warnings show (see image above) and the pending links point to the expected places.