Solved segfault from python.

metacall · Apr 18, 2023 · 73b546f · 73b546f
1 parent 740022c
commit 73b546f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/source/loaders/py_loader/source/py_loader_impl.c b/source/loaders/py_loader/source/py_loader_impl.c
@@ -1538,6 +1538,7 @@ PyObject *py_loader_impl_value_to_capi(loader_impl impl, type_id id, value v)
 	{
 		/* TODO */
 		log_write("metacall", LOG_LEVEL_ERROR, "TODO: Python future not implemented yet for arguments");
+		Py_RETURN_NONE;
 	}
 	else if (id == TYPE_FUNCTION)
 	{

diff --git a/source/ports/rs_port/tests/loaders_test.rs b/source/ports/rs_port/tests/loaders_test.rs
@@ -29,6 +29,7 @@ fn load_from_memory_test() {
     call_greet("load_from_memory", 1);
 }
 
+// TODO: Why not putting this into a script inside scripts folder?
 fn load_from_file_test() {
     // Finding a temporary address to store the temporary js file
     let temp_js_pathbuf =

diff --git a/source/ports/rs_port/tests/metacall_test.rs b/source/ports/rs_port/tests/metacall_test.rs
@@ -413,6 +413,6 @@ fn metacall() {
         test_null();
         test_string();
         test_throwable();
-        // test_future();
+        test_future();
     }
 }