Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid computing average and totals for components that didn't output power #94

Closed
metacosm opened this issue Jul 7, 2024 · 1 comment · Fixed by #97
Closed

Avoid computing average and totals for components that didn't output power #94

metacosm opened this issue Jul 7, 2024 · 1 comment · Fixed by #97
Assignees
@metacosm

Comments

@metacosm
Copy link
Owner

metacosm commented Jul 7, 2024

No description provided.

@metacosm metacosm self-assigned this Jul 7, 2024
@metacosm
Copy link
Owner Author

metacosm commented Jul 9, 2024

Averages and totals are incrementally computed for each value so this doesn't really matter. However, standard deviation is computed by going over all the measures up to that point so if all the values are zero, there really is no point in computing this.

metacosm added a commit that referenced this issue Jul 9, 2024
@metacosm
feat: only compute std dev on components that output values
cc59f1a 
Fixes #94
@metacosm metacosm mentioned this issue Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metacosm metacosm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: only compute std dev on components that output values metacosm/power-server
1 participant
@metacosm