-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Upgrade all Nix deps, Nodejs, Yarn, TypeScript, switch to Yarn PnP and package all beacon-light-client/plonky2 services #203
Conversation
41c740b
to
2684d42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the binary files and the various copy and old.nix files in this PR intended for committing?
06c8ff7
to
f60e208
Compare
f60e208
to
ce8b755
Compare
b5ce2f6
to
13d2496
Compare
b264633
to
c85a51b
Compare
b7e69ac
to
f6d0402
Compare
950bede
to
7c13894
Compare
a8d0fd7
to
7dbf918
Compare
Need for isolated builds of yarn-plugin-nixify See also: * https://github.com/stephank/yarn-plugin-nixify/blob/main/ISOLATED_BUILDS.md * https://yarnpkg.com/features/pnp
See this for more info: https://yarnpkg.com/getting-started/editor-sdks
Emscripten expect the JS-host to provide this import since v3.1.46 and this PR: emscripten-core/emscripten#20144
…ponding test Intead of batching the compilation before all tests, as when a test fail it is more difficult to figure out which one.
e188d5e
to
ee4dc2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🤌
Finally we can 🛳️ it!
…s `-l $CIRCOM_LIB` This tests don't need to use relative imports from node_modules.
937880b
to
8656026
Compare
include "../../../node_modules/circomlib/circuits/sha256/sha256.circom"; | ||
include "../../../node_modules/circomlib/circuits/bitify.circom"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤢🤮🤢🤮
Ty for the clean up of this mess!!
metacraft-labs.circom | ||
( | ||
pkgs.writeShellScriptBin "circom" '' | ||
${metacraft-labs.circom}/bin/circom -l "$CIRCOM_LIB" "$@" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Miracle 👼👼👼
Thank you @EmilIvanichkovv for all the pair-programming sessions! |
Merge queue setting changed
nodeLinker
topnp
- by @PetarKirovyarn-plugin-nixify
plugin - by @MartinNikovcraneLib-nightly
- by @MartinNikovcommitment_mapper_builder
- by @MartinNikovrust-nightly
- by @MartinNikovcircuits_executables
- by @MartinNikovbalance-verifier
packages - by @MartinNikovget_balances_inputs
package - by @MartinNikovcolors
- by @PetarKirovrust-src
andrust-analyzer
components to the rust-nightly package - by @PetarKirovyarn-project.nix
file - by @PetarKirovyarn format:write
- by @PetarKirovmagic-nix-cache-action
and updatenix-installer-action
andcachix-action
- by @PetarKirovts-node
in the $PATH - by @PetarKirov@lodestar/types
dep - by @PetarKirov@chainsafe/ssz
and@lodestar/types
- by @PetarKirovbuild:{tsc,sol}
scripts to workspaces - by @PetarKirovyarn tsc
- by @PetarKirovts
script based ontsx
- by @PetarKirovhardhat-gas-reporter
to allowhardhat test
to pass - by @PetarKirovemscripten_memcpy_js
- by @PetarKirovETHEREUM_MAINNET_RPC
to a working provider - by @PetarKirovcircomlib
so that it can be physically visible fromcircom
- by @PetarKirovcircom
wrapper that passes-l $CIRCOM_LIB
- by @PetarKirovtsx
as dev dep - by @PetarKirov