Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade all Nix deps, Nodejs, Yarn, TypeScript, switch to Yarn PnP and package all beacon-light-client/plonky2 services #203

Merged
merged 62 commits into from
Mar 22, 2024

Conversation

PetarKirov
Copy link
Collaborator

@PetarKirov PetarKirov commented Aug 7, 2023

@PetarKirov PetarKirov force-pushed the feat/commitment_mapper_builder_nix_package branch from 41c740b to 2684d42 Compare August 7, 2023 11:47
Copy link
Member

@zah zah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the binary files and the various copy and old.nix files in this PR intended for committing?

Base automatically changed from plonky2 to main August 14, 2023 14:22
@MartinNikov MartinNikov force-pushed the feat/commitment_mapper_builder_nix_package branch 2 times, most recently from 06c8ff7 to f60e208 Compare September 20, 2023 10:41
@MartinNikov MartinNikov force-pushed the feat/commitment_mapper_builder_nix_package branch from f60e208 to ce8b755 Compare November 1, 2023 14:55
@monyarm monyarm force-pushed the feat/commitment_mapper_builder_nix_package branch from b5ce2f6 to 13d2496 Compare November 20, 2023 14:56
@PetarKirov PetarKirov force-pushed the feat/commitment_mapper_builder_nix_package branch 5 times, most recently from b264633 to c85a51b Compare February 20, 2024 16:13
@PetarKirov PetarKirov force-pushed the feat/commitment_mapper_builder_nix_package branch 2 times, most recently from b7e69ac to f6d0402 Compare February 29, 2024 08:43
@PetarKirov PetarKirov force-pushed the feat/commitment_mapper_builder_nix_package branch from 950bede to 7c13894 Compare March 8, 2024 12:41
@PetarKirov PetarKirov force-pushed the feat/commitment_mapper_builder_nix_package branch 2 times, most recently from a8d0fd7 to 7dbf918 Compare March 21, 2024 18:27
Emscripten expect the JS-host to provide this import since v3.1.46 and this PR:
emscripten-core/emscripten#20144
…ponding test

Intead of batching the compilation before all tests, as when a test fail it is
more difficult to figure out which one.
@PetarKirov PetarKirov force-pushed the feat/commitment_mapper_builder_nix_package branch from e188d5e to ee4dc2f Compare March 22, 2024 16:53
@EmilIvanichkovv EmilIvanichkovv self-requested a review March 22, 2024 17:28
Copy link
Contributor

@EmilIvanichkovv EmilIvanichkovv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤌
Finally we can 🛳️ it!

@PetarKirov PetarKirov force-pushed the feat/commitment_mapper_builder_nix_package branch from 937880b to 8656026 Compare March 22, 2024 21:05
Comment on lines -3 to -4
include "../../../node_modules/circomlib/circuits/sha256/sha256.circom";
include "../../../node_modules/circomlib/circuits/bitify.circom";
Copy link
Contributor

@EmilIvanichkovv EmilIvanichkovv Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤢🤮🤢🤮

Ty for the clean up of this mess!!

metacraft-labs.circom
(
pkgs.writeShellScriptBin "circom" ''
${metacraft-labs.circom}/bin/circom -l "$CIRCOM_LIB" "$@"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miracle 👼👼👼

@EmilIvanichkovv EmilIvanichkovv requested a review from Xearty March 22, 2024 21:11
@EmilIvanichkovv EmilIvanichkovv added the circom Tasks and Issues related to circom circuits label Mar 22, 2024
@PetarKirov PetarKirov changed the title build(nix): Package plonky2 circuits Some tweaks Mar 22, 2024
@PetarKirov PetarKirov enabled auto-merge March 22, 2024 21:15
@PetarKirov PetarKirov changed the title Some tweaks build: Upgrade all Nix deps, Nodejs, Yarn, TypeScript, switch to Yarn PnP and package all beacon-light-client/plonky2 services Mar 22, 2024
@PetarKirov
Copy link
Collaborator Author

Thank you @EmilIvanichkovv for all the pair-programming sessions!

@PetarKirov PetarKirov added this pull request to the merge queue Mar 22, 2024
auto-merge was automatically disabled March 22, 2024 21:24

Merge queue setting changed

@PetarKirov PetarKirov removed this pull request from the merge queue due to the queue being cleared Mar 22, 2024
@PetarKirov PetarKirov merged commit af22403 into main Mar 22, 2024
14 checks passed
@PetarKirov PetarKirov deleted the feat/commitment_mapper_builder_nix_package branch March 22, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build circom Tasks and Issues related to circom circuits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants