fix(generator): export type Expectation #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
our automated mocha tests are failing as the typescript compiler fails with the message Parameter 'expected' of public static method from exported class has or is using private name 'Expectation' Since this type is consumed by external clients, with one of the latest TypeScript versions we do get this issue
|
This doesn't completely fix the issue. You also need to export |
|
@stifflerus thanks for the catch, another reason why the tests might be useful :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
our automated mocha tests are failing as the typescript compiler fails with the message
Parameter 'expected' of public static method from exported class has or is using private name 'Expectation'
Since this type is consumed by external clients, with one of the latest TypeScript versions we do get this issue