Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MarcXmlHandler.java #504

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

TobiasNx
Copy link
Contributor

@TobiasNx TobiasNx commented Oct 13, 2023

Update documentation for namespace handling in handle-marcxml.

See: hbz/lobid-resources#1348 (comment)

Update documentation for namespace handling in decode-marcxml.

See: hbz/lobid-resources#1348 (comment)
Copy link
Member

@dr0i dr0i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's handle-marcxml, not decode-marcxml, right ?
If you want the documentation appear into the flux-commands you have to also follow https://github.com/metafacture/metafacture-core/wiki/Flux-user-guide#adding-new-commands.

@dr0i dr0i assigned TobiasNx and unassigned dr0i Oct 13, 2023
@TobiasNx
Copy link
Contributor Author

It's handle-marcxml, not decode-marcxml, right ? If you want the documentation appear into the flux-commands you have to also follow https://github.com/metafacture/metafacture-core/wiki/Flux-user-guide#adding-new-commands.

Your right.
But I will wait until the next runner release of fix. Because we now build the documentation with the runner of fix.

@dr0i
Copy link
Member

dr0i commented Oct 13, 2023

Why wait - if you don't change the description it will not be generated. And if you want that I build the flux-commands.md - I can do that ( it affects another repo).

@TobiasNx
Copy link
Contributor Author

@dr0i could we merge this?

@TobiasNx
Copy link
Contributor Author

With the new changes to core, we could add new releases to FLUX and FIX and also update the documentation.

@dr0i dr0i merged commit 67dbabd into master Apr 25, 2024
1 check passed
@dr0i
Copy link
Member

dr0i commented Apr 25, 2024

Will merge. flux-commands.md will be generated at least when releasing so we don't need to update it adhoc. Closed.

@dr0i dr0i deleted the documentNamespaceBehaviourForDecodeMarcXml branch April 25, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants