Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Vars support. #91

Merged
merged 3 commits into from
Dec 13, 2021
Merged

Extend Vars support. #91

merged 3 commits into from
Dec 13, 2021

Conversation

blackwinter
Copy link
Member

Resolves #88.

@blackwinter blackwinter requested a review from fsteeg December 9, 2021 10:55
@fsteeg fsteeg assigned blackwinter and unassigned fsteeg Dec 9, 2021
@blackwinter
Copy link
Member Author

That was quick :) Thanks!

@blackwinter
Fix for unmodifiable vars from Flux. (#91)
8bf84ac 
See `FlowBuilder.VarRef` in metafacture-flux.
@blackwinter
Keep separate (mutable) map for vars. (#91)
887d6c6 
Equivalent to Metamorph (via AbstractMetamorphDomWalker).
@blackwinter
Copy link
Member Author

Merging despite unresolved conversation. We can still revert/update later.

@blackwinter blackwinter merged commit 966e09f into master Dec 13, 2021
@blackwinter blackwinter deleted the 88-extendVarsSupport branch December 13, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsteeg fsteeg fsteeg approved these changes

Assignees

@blackwinter blackwinter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend Vars support.
2 participants
@blackwinter @fsteeg