-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazyload picture #1109
base: master
Are you sure you want to change the base?
Lazyload picture #1109
Conversation
- Allow picture source tags to be lazy loaded
picture tag lazy loading
- added test
- updated source tag test - not setting src attribute if none preset
- check img tag name before setting property 'src'
Borrowed from metafizzy#1109
Thank you so much for this contribution. I plan on working on Flickity again in 2021. This feature will be evaluated for merging in then. Thank you for your patience. |
This fixes the issue for me. Thank you! |
As a side-note: I wasn't able to get this to work with flickity-fade. But that probably has to do with my lack of npm foo 😄 |
I'd strongly welcome if this feature would be merged into Flickity. |
Any info on this? @desandro Thanks! |
Used this update today to help speed up a client site using picture tag for displaying different images for mobile/desktop. This should definitely make it into the main branch! |
It's been 5 years since original issue --> #161 (comment) Can we please merge this and create a release? |
I'd like to see this pull request merged so I can use the |
Hi, When this PR will get merged? |
This merge request adds a desired feature: Lazy loading for picture/source elements.
This feature is important as srcset attribute cannot handle pixel density and viewport width at the same time.