Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kegg forms #123

Merged
merged 5 commits into from
Aug 8, 2024
Merged

Fix kegg forms #123

merged 5 commits into from
Aug 8, 2024

Conversation

njohner
Copy link
Contributor

@njohner njohner commented Aug 8, 2024

Selection with the autocomplete widget was not working for the kegg-based comparative analysis form. We have fixed this by using crispy forms to render the forms on the kegg-based view. We have also improved the overall layout and style of the view as shown in the screenshots below.

Kegg based view before fix
kegg_befor_fix

Kegg based view after fix
kegg_after_fix

Checklist

  • Changelog entry
  • Check that tests still pass
  • Add tests for new features and regression tests for bugfixes whenever possible.

In order for the selection widget to work we now use crispy forms.
While at it we port all forms from the kegg based view to crispy
forms, matching the rendering to other forms in the app.
@njohner njohner changed the base branch from master to nj/fix_static_files August 8, 2024 13:22
Base automatically changed from nj/fix_static_files to master August 8, 2024 14:25
@njohner njohner merged commit 205a8df into master Aug 8, 2024
@njohner njohner deleted the nj/fix_kegg_forms branch August 8, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant