-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AMR tabular comparison view. #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njohner
force-pushed
the
nj/amr_views
branch
from
December 20, 2023 13:23
cf1debc
to
2fa776e
Compare
These views had a lot of unnecessary white space.
njohner
force-pushed
the
nj/amr_views
branch
from
December 28, 2023 15:43
6ebab7e
to
8a3b3f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we add a new view for AMR gene comparison between taxons. As there were already several such tabular comparison views and they are all similar, we refactor those views and write them as class-based views to allow for easier code reuse.
Currently the table allows to compare the presence of specific AMR genes and the cells are colored according to the quality of the best hit for a given taxon. I plan to include grouping by class or subclass in the near future.
This PR bases on #23