Port nextflow pipelines to DSL2 language. #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting values for a path channel is not allowed. We could probably mount empty files instead, but it is not necessary, we can simply chain the load statements by conditionnally overwriting always the same variable "db". This is much cleaner and easier to read.
Instead of having if conditions repeated several times in the pipeline we group the processes corresponding to a given option.
|
I'll start merging my PRs, because I have 5 stacked on top of each other, so I anyway don't want to rebase everything. You guys can still have a look and make comments if you want and I can include the changes in an upcoming PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we port the nextflow pipelines to the DSL2 language. To avoid braking anything I've also added a series of unitests for the pipelines.