Add AMR comparison index view and link it in the menu and home page. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njohner
changed the title
njohner
changed the title
njohner
force-pushed
the
nj/amr_home
branch
2 times, most recently
from
e627626
to
da45c9d
Compare
type is a reserved keyword and should not be used as variable name.
Capitalization in URLs is unusual and makes things more complex. Moreover it was not used consistently, so I decided to drop it.
I also fix the indentation to improve readability.
We add a field to the form to choose the type of comparison to make.
This makes using the same templates for the comparison index view easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I add a comparison index view for the AMR analyses and add a link to it in the menu and on the home page. I also merge the three tabular comparisons (gene, class and subclass presence/absence) into one view with a selection field to choose which type of comparison to make. See screenshots below.