Add AMR venn diagram view #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests currently fail for the venn subset views and for the venn_pfam view because they are broken and do not show the page title. Moreover the tests fail for the venn_amr view which does not exist yet. Also note that the table is broken in the ko_venn_subset view and does not show any data.
I don't understand why we are going to all the trouble of making strings out of the variables before passing them to the template.
Close row tag before opening next row tag.
Note that we lost filtering of COGs without description in the process. I'm not sure that it's really a problem though.
This was lost wenn rewriting the venn_cog view as class-based.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we rewrite the Venn diagram views as class-based views to avoid code duplication. Then we add the Venn diagram view for the AMRs. In the process we fix a couple of bugs:
venn_pfamviewko_venn_subsetviewChecklist