Add reference DB and software versions to database. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njohner
force-pushed
the
nj/db_versions2
branch
from
14326fd
to
1304cd2
Compare
njohner
force-pushed
the
nj/db_versions2
branch
from
1304cd2
to
b2dff95
Compare
njohner
changed the title
tpillone
reviewed
Feb 9, 2024
There was a problem hiding this comment.
ko_hits, pfam_hits, swissprot_hits, amr_hits,... counts might also change depending the database version
There was a problem hiding this comment.
Yes of course you're right. I'd also thought about that but decided not to change the tests proactively, but adapt them when needed. But it's clear that the tests are a bit fragile...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we add a new "versions" table to the database and store the versions of the different reference databases used as well as of the AMRFinderPlus software in it. We display that information on the home page of zDB.
Checklist