Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webapp bug fixes and view improvements. #59

Merged
merged 11 commits into from
Feb 27, 2024
Merged

Webapp bug fixes and view improvements. #59

merged 11 commits into from
Feb 27, 2024

Conversation

njohner
Copy link
Contributor

@njohner njohner commented Feb 23, 2024 •
edited
Loading

Just a few small improvements and bug fixes here, notably:

  • Fix AMR tabular comparison views
  • Fix counts for all genomes in hit extraction views
  • Fix GC content in genomes views. When I bumped biopython to 1.8 and replaced the deprecated SeqUtils.GC with SeqUtils.gc_fraction I did not realize the former gave a percentage while the latter gives the fraction. I also fix it in metagenlabl_libs
  • Show xaxis labels as links in heatmap view.

Checklist

  • Changelog entry -> no CL
  • Check that tests still pass
  • Add tests for new features and regression tests for bugfixes whenever possible.

@njohner njohner changed the title Nj/view improvements Webapp bug fixes and view improvements. Feb 23, 2024
@njohner njohner marked this pull request as ready for review February 23, 2024 09:24
@njohner njohner merged commit f8c1ef5 into master Feb 27, 2024
@njohner njohner deleted the nj/view_improvements branch February 27, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@njohner