-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GWAS analyses using Scoary2 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njohner
force-pushed
the
nj/scoary
branch
2 times, most recently
from
February 27, 2024 09:53
a481a87
to
fb1cb1b
Compare
njohner
force-pushed
the
nj/scoary
branch
2 times, most recently
from
February 28, 2024 16:13
53de367
to
e10e75d
Compare
For now the views simply allow to select genomes as having a given phenotype, while the others are considered as not having it.
For orthogroups, the get_hit_descriptions method did not return a dataframe with one entry per hit, contrary to the same function for all other mixins. We therefore modify it to include processing of the data returned by the SQL query so that it returns a DataFrame similar to get_hit_descriptions from other mixins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we add views for GWAS for all annotation types.
For now the phenotype is defined by selecting species with the phenotype from a list. There are no other configuration parameters yet. I will add a dedicated form with the possibility to upload a phenotype file in a later PR.
The results are presented in tabular form. Other types of representations will be added separately.
Below an example screenshot for the GWAS analysis view and the box shown in the comparison index views.
Checklist