Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GWAS analyses using Scoary2 #62

Merged
merged 12 commits into from
Mar 5, 2024
Merged

Add GWAS analyses using Scoary2 #62

merged 12 commits into from
Mar 5, 2024

Conversation

njohner
Copy link
Contributor

@njohner njohner commented Feb 27, 2024

With this PR we add views for GWAS for all annotation types.

For now the phenotype is defined by selecting species with the phenotype from a list. There are no other configuration parameters yet. I will add a dedicated form with the possibility to upload a phenotype file in a later PR.

The results are presented in tabular form. Other types of representations will be added separately.

Below an example screenshot for the GWAS analysis view and the box shown in the comparison index views.
gwas

gwas_box

Checklist

  • Changelog entry
  • Check that tests still pass
  • Add tests for new features and regression tests for bugfixes whenever possible.

@njohner njohner force-pushed the nj/scoary branch 2 times, most recently from a481a87 to fb1cb1b Compare February 27, 2024 09:53
@njohner njohner changed the title Nj/scoary Add GWAS analyses using Scoary2 Feb 27, 2024
Base automatically changed from nj/cleanup_templates to master February 28, 2024 12:35
@njohner njohner changed the base branch from master to nj/bug_fixes2 February 28, 2024 13:35
Base automatically changed from nj/bug_fixes2 to master February 28, 2024 13:45
@njohner njohner force-pushed the nj/scoary branch 2 times, most recently from 53de367 to e10e75d Compare February 28, 2024 16:13
@njohner njohner changed the base branch from master to nj/fix_blast February 28, 2024 16:14
For orthogroups, the get_hit_descriptions method did not return
a dataframe with one entry per hit, contrary to the same function
for all other mixins. We therefore modify it to include processing
of the data returned by the SQL query so that it returns a
DataFrame similar to get_hit_descriptions from other mixins.
Base automatically changed from nj/fix_blast to master March 1, 2024 11:44
@njohner njohner requested review from bkm and tpillone March 1, 2024 11:57
@njohner njohner marked this pull request as ready for review March 1, 2024 12:38
@njohner njohner merged commit 2961e00 into master Mar 5, 2024
@njohner njohner deleted the nj/scoary branch March 5, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant