Add VFs to locus and orthogroup views. #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njohner
force-pushed
the
nj/locus_vf
branch
2 times, most recently
from
ebc857b
to
24ead1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we add the virulence factors to the orthogroup and locus views. They are currently displayed as a simple table, which can get very long. Maybe we should do as for swissprot homologs and display the VFs as a datatable, with paging. We'll see what the situation is once we introduce identity filtering for VFs to the annotation pipeline.
We also refactor the locus and orthogroup views to diminish code repetition and cleanup the html templates.
Checklist