Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle group_0 in EntryIdParser. #93

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Correctly handle group_0 in EntryIdParser. #93

merged 1 commit into from
Jun 17, 2024

Conversation

njohner
Copy link
Contributor

@njohner njohner commented Jun 17, 2024

group_0 was not correctly mapped back to the orthogroup with ID 0, leading to issues for example when selecting that group for a custom phylogeny plot.

Checklist

  • Changelog entry
  • Check that tests still pass
  • Add tests for new features and regression tests for bugfixes whenever possible.

@njohner njohner merged commit b1e735d into master Jun 17, 2024
@njohner njohner deleted the nj/fix_entryid_parser branch June 17, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@njohner