check if unused import warning is enabled before adding import to stack

fixes nim-lang#24552
metagn · Dec 20, 2024 · 042edaa · 042edaa
1 parent ce4304c
commit 042edaa
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/compiler/importer.nim b/compiler/importer.nim
@@ -248,7 +248,8 @@ proc importModuleAs(c: PContext; n: PNode, realModule: PSym, importHidden: bool)
     result.options.incl optImportHidden
   let moduleIdent = if n.kind in {nkInfix, nkImportAs}: n[^1] else: n
   result.info = moduleIdent.info
-  c.unusedImports.add((result, result.info))
+  if warnUnusedImportX in c.config.notes:
+    c.unusedImports.add((result, result.info))
   c.importModuleMap[result.id] = realModule.id
   c.importModuleLookup.mgetOrPut(result.name.id, @[]).addUnique realModule.id
 

diff --git a/tests/import/tpushunusedwarning.nim b/tests/import/tpushunusedwarning.nim
@@ -0,0 +1,9 @@
+# issue #24552
+
+{.warningAsError[UnusedImport]: on.}
+{.push warning[UnusedImport]: off.}
+import tables
+{.pop.}
+
+proc test*(a: float): float =
+  a