Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a daoURI adoption path through EAS for the Optimism Foundation #170

Closed
amanwithwings opened this issue Nov 1, 2023 · 26 comments
Closed
Assignees
Labels
priority: high High priority

Comments

@amanwithwings
Copy link
Collaborator

  1. Deploy an EIP-4824 schema on EAS
  2. See if registrations through EAS can be indexed
  3. Get the Optimism Foundation to publish a daoURI for the OP Collective.
@crazyyuan
Copy link
Collaborator

Well, I'm glad to do something on EAS.
And I have some questions about technical implementation.

  • Is it related to the factory contract existed? If yes, we need to refactor the factory contract to integrate with EAS. So the contracts on different chains will be redeployed.
  • Whether the registrations through EAS have any restrictions? If not, somebody can easily make attestations under the schema. Some junk attestations will generate which we can't identify. If yes, the resolver contract point to the schema should be programmed.

@crazyyuan
Copy link
Collaborator

Schema: Used to publish daoURI. Before it, someone should be granted a member role by DAOstar.

Schema: Used to change daoURI, just for someone with DAO manager role.

@crazyyuan
Copy link
Collaborator

This is the flow diagram showing how the technology works.
tech_architecture-EIP4824_EAS drawio

@Rashmi-278
Copy link
Member

I think we should implement DAO URI using EAS and Not the EIP 4824, it makes more sense to me
At the end of the day DAO URI and it contents that is Attested is more relevant and more trust worthy than the DAO URI created by a registration form from our frontend. Because anyone can create a DAO URI from the reistration form, its not signed/attested

A DAO URI created with EAS attestation either onchain/offchain, someone attests it, from a wallet address/ens name/DAO address
and then they make an EIP-4824 registration contract summoner with an onchain transaction from their DAO

I believe this would make the standard more credible and also make creating the DAO URI more "decentralized" (right now, we are the only one hosting the registration form to create the DAO URI)

Next steps would be to modify the contract to listen to the DAO URI attestations and just display it on our frontend. We would NOT need our Subgraphs, nor the DAO URI API infrastucture

But we would need to implement the Framework customization ( Snapshot, DAODAO, custom, moloch, safe etc) with an EAS attestation.
We could do this easily by having a field on DAO URI for framework and a resolver contract which generates the Framework URI links for say Snapshot or any other framework

We need to think about "incentivising" the DAO Framework URI to be maintained by the framework maintainers themselves as it would be more in sync with any changes/updates a framework makes

@Rashmi-278
Copy link
Member

Rashmi-278 commented Nov 6, 2023

Related Issue:
#170

@thelastjosh
Copy link
Member

thelastjosh commented Nov 8, 2023

So just to be clear, we are going to have an EAS registration option where someone can publish a daoURI through EAS. Details of that are still TBD.

However, @Rashmi-278 's proposal above is about changing the way that daostar.org works—i.e. replacing part of our process with a call to EAS. We agreed however that this is not necessarily the highest priority right now, though it may be a better option in the future if we can get away with NOT hosting additional infrastructure. Not, however, that sending it to EAS just means sending it to another entity's centralized server so does not come with many additional security guarantees, and introduces some dependency risks.

@thelastjosh
Copy link
Member

No update yet, we need to finish writing the specification.

@thelastjosh
Copy link
Member

Effectively a way we could integrate the EAS adoption path is through usage of existing credentials (such as Twitter or GitHub verification) provided by trusted issuers such as Gitcion. This is not a fullproof method against spoofing, but it gives a mild level of assurance. If/when we implement this, I feel some some sort of expiration on such attestations makes sense.

@thelastjosh
Copy link
Member

@thelastjosh
Copy link
Member

thelastjosh commented Dec 6, 2023

Mike, Kahn, and Aman discussed it yesterday. Aman will share notes from doc here. Basic gist: once RPGF is over, we just need to ping Justine to do it.

Discussed: can a EAS attestation have a "manager" field? In that case, the OP Collective can create + sign the attestation, then the OP DAO becomes a "manager" of the attestation.

@crazyyuan
Copy link
Collaborator

crazyyuan commented Dec 13, 2023

I created a new schema for this issue without a resolver contract. It's very simple and anyone can attest.
https://optimism-goerli-bedrock.easscan.org/schema/view/0x5e7633bad97b4b8e8248b93aa8f9bfa6b905f7eeb70a8b2053b460f0a2d44f1f

@amanwithwings
Copy link
Collaborator Author

@Rashmi-278, could you make sure attestations from the above schema are indexed and displayed on our explore page? If working, we'll deploy it on OP mainnet.

@crazyyuan
Copy link
Collaborator

I think the registration process may need to be optimized. When registering, call the EAS API attest to publish the daoURI instead of via EASSCAN.
@Rashmi-278 I can provide some technical help about integrating with EAS If you need it.

@Rashmi-278
Copy link
Member

Rashmi-278 commented Dec 20, 2023 via email

@amanwithwings
Copy link
Collaborator Author

Any updates on this issue, @Rashmi-278?

@Rashmi-278
Copy link
Member

I'm still working on this, will update next week again

@amanwithwings
Copy link
Collaborator Author

Where we stand now: we need to finalize the schema.

Publishing a daoURI for OP Collective: 1) through ENS (seems like the best option now), OR 2) through EAS.

Find out: who controls OP Collective's ENS.

@Rashmi-278
Copy link
Member

#198

EAS attestations displayed

image

Added to documentation

image

@thelastjosh
Copy link
Member

thelastjosh commented Jan 24, 2024 via email

@Rashmi-278
Copy link
Member

Rashmi-278 commented Jan 24, 2024 via email

@thelastjosh
Copy link
Member

Just noting that the current plan is for Optimism Collective to publish a daoURI through BOTH the ENS/DNS pathway as well as the Optimism Foundation -> EAS attestation -> Optimism Collective pathway.

@Rashmi-278
Copy link
Member

Duplicate or Similar Issue: #60

We already have created an Schema on OP-Goerli and are indexing the on-chain and offChain Attestations

https://optimism-goerli-bedrock.easscan.org/schema/view/0x5e7633bad97b4b8e8248b93aa8f9bfa6b905f7eeb70a8b2053b460f0a2d44f1f

@Rashmi-278
Copy link
Member

As EAS OP Goerli Bedrock support was deprecated, Our EAS Attestations made previously are not being displayed on frontend.
Here's a doc on changes needed when we have a new Schema up on OP Goerli Network
https://hackmd.io/@torchablazed/Sk8GpOlRp

Reference Issue: #170

Copy link

linear bot commented Apr 22, 2024

@amanwithwings
Copy link
Collaborator Author

yay!

@amanwithwings
Copy link
Collaborator Author

yes*2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high High priority
Projects
None yet
Development

No branches or pull requests

4 participants