proposalsURI for Snapshot DAOs

[amanwithwings]

Check out the proposalsURI Snapshot publishes: https://hub.snapshot.org/api/eip4824/opcollective.eth/proposals

This is a sample proposalURI our Register service creates: https://services.daostar.org/api/v1/snapshot/proposals/opcollective.eth

The former returns more data. I feel like we can easily return more data (and we should) through our proposalsURI. See the proposalsURI JSON-LD schema suggested by the standard: https://daostar.one/EIP. In short, this issue was created to examine if the proposalsURI we create now needs to be fleshed out more.

@Rashmi-278, I'm assigning this to you but let's wait until @thelastjosh has a look to start working.

[Rashmi-278]

Sure Aman. I propose that we include members URI for Snapshot too.

It's the same case with that too.
An example might be, ENS registration instance.

[thelastjosh]

I agree with Aman.

On Fri, Feb 2, 2024 at 9:29 PM Rashmi V Abbigeri ***@***.***> wrote: Sure Aman. I propose that we include members URI for Snapshot too. It's the same case with that too. An example might be, ENS registration instance. — Reply to this email directly, view it on GitHub <#203 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACHA5PBCG47SRTHFRUJATADYRWVJPAVCNFSM6AAAAABCXIBE7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVGA2DANJXGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- joshuatan.com/research

[Rashmi-278]

Moving this to High Prio

[amanwithwings]

Aman <> Rashmi (14.02.2023)

Questions:

1. Does title need to be a separate field (it's also inside contentURI)
2. Any comments on the contentURI generated below?

Wondering if we should also share the membersURI we created for Lodestar to Snapshot (@Rashmi-278 could submit a PR and ask them to review it ).

[Rashmi-278]

This would the data included in the ContentURI for a Proposal

{
"data": {
"proposal": {
"id": "0xc9c0a739a29ce6477708f49a2985e4c8cb2e4ba0be1d3761541ed189a9c341e1",
"ipfs": "bafkreia4vvwaa4huhtonsyq33assjtb5hgo3if3gqpmaxab2hvtrjiogn4",
"author": "0x83E54889754e737Fb3CdF07BAaCC0eB9699B6Bdd",
"plugins": {},
"title": "Season 2: Cycle 8: Angle",
"body": "This Governance Fund Phase 1 proposal is eligible for voting in Cycle 8. This is the last Voting Cycle of Season 2. \n\nThis proposal was reviewed by DeFi Committee C. You can find committee recommendations below:\nDeFi Committee C Recommendations\n\nShadow DeFi Committee B is not an official committee but posts their own recommendations here: https://gov.optimism.io/t/defi-shadow-committee-season-2-recommendations/3549/11\n \nBy approving committees, the Token House entered a social contract to entrust and delegate the bulk of decision-making to official committees. However, delegates may vote against the recommendation of official committees but should provide a justification to the community as to why they voted differently.",
"discussion": "https://gov.optimism.io/t/review-gf-phase-1-proposal-angle-protocol/2552/55",
"privacy": "",
"snapshot": "30456637",
"state": "closed",
"link": "https://snapshot.org/#/opcollective.eth/proposal/0xc9c0a739a29ce6477708f49a2985e4c8cb2e4ba0be1d3761541ed189a9c341e1",
"app": "snapshot"
}
}
}

Snapshot Query

query Proposal($proposalId: String) {
proposal(id: $proposalId) {
id
ipfs
author
plugins
title
body
discussion
privacy
snapshot
state
link
app
}
}

[Rashmi-278]

More Context on above: Me and Aman discussed the differences in the content returned by our API and Snapshot's API.
Although there is no differences between the number of proposals returned, Snapshot's API returns the title of proposal with the proposal ID and DAOstar doesn't.

According to EIP-4824, any content such as title and more info on proposals should be inside contentURI of a proposal, what additional content should we provide for a proposal through our API is what being discussed above.

[Rashmi-278]

Referencing EIP-4824 Proposal URI JSON, created a PR to add more fields to Snapshots Proposals URI
https://github.com/snapshot-labs/snapshot-hub/pull/911/files

[Rashmi-278]

This issue has been worked and completed, Snapshot Merged our PR