Evaluator #28
Merged
Evaluator #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
SolusEngineclass intoEvaluator. In the future, the evaluator will be the primary way of evaluating expressions, instead of recursively callingEvalon the nodes in an expression tree. This will allow for new optimizations to be used to speed up evaluation.Also, this PR adds a lot of tests. Most of the
Functions are getting tested for the first time.This PR also renames
PreliminaryEvaltoSimplify, and changes the simplification ofVariableAccessso that it doesn't involve variable substitution, which is outside the scope. A new class,ApplyVariablesTransformer, has been added to do that.