Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment Pipeline #132

Merged
merged 4 commits into from
Apr 20, 2024
Merged

Deployment Pipeline #132

merged 4 commits into from
Apr 20, 2024

Conversation

proffapt
Copy link
Member

@proffapt proffapt commented Apr 20, 2024

resolves #118

Questions

Any path to ignore? Changes there won't trigger this pipeline.

@harshkhandeparkar
Copy link
Member

All paths except the service containers (/nginx, /mediawiki, /mysql, and /jobs) and the docker files can be ignored. Currently working on updating the docs and we don't want the wiki to be redeployed each time the readme changes.

@harshkhandeparkar
Copy link
Member

LGTM otherwise.

chirag-ghosh
chirag-ghosh previously approved these changes Apr 20, 2024
@chirag-ghosh
Copy link
Member

chirag-ghosh commented Apr 20, 2024

LGTM otherwise.

Toh bhaiya approve karo na

@proffapt
Copy link
Member Author

All paths except the service containers (/nginx, /mediawiki, /mysql, and /jobs) and the docker files can be ignored. Currently working on updating the docs and we don't want the wiki to be redeployed each time the readme changes.

Ok, lemme make this change then

@proffapt
Copy link
Member Author

But, docker-compose, docker-compose.prod.yml.. and these things are important too ¯_(ツ)_/¯

So please mention those files which are to be ignored.

@harshkhandeparkar
Copy link
Member

But, docker-compose, docker-compose.prod.yml.. and these things are important too ¯_(ツ)_/¯

So please mention those files which are to be ignored.

Keep the composefiles and ignore the rest.

@proffapt proffapt changed the title Cd pipeline Deployment Pipeline Apr 20, 2024
@rajivharlalka rajivharlalka merged commit 9371101 into master Apr 20, 2024
@proffapt proffapt deleted the cd-pipeline branch April 20, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic Deployment?
4 participants