Update mediawiki to 1.32.2 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Version 1.30 is no more supported - Update extensions accordingly I'll use the following procedure once the PR is approved to update on prod. - Take the latest backup of the server and store it locally. - `git pull` and `docker-compose build` - `docker-compose down` - `docker volume rm <mediawiki-volume` - `docker-compose exec php /srv/mediawiki/maintenance/update.php` - `docker-compose up --build -d` - `./script/restore-from-backup.sh <path to sql file>`
|
The test is failing since at the moment this page is not working: https://www.mediawiki.org/wiki/Special:ExtensionDistributor
|
|
When doing an upgrade or restart, you don't need to restore from backup
(you should still definitely take the backup in case anything goes wrong).
The database is on the mysql volume, which persists through the upgrade.
I think the containers need to be running before you can run update.php,
and the docker-compose command needs to be fed the prod configuration files
(there's an example in the runbook).
…On Sat, 15 Jun 2019 at 13:07, Shivam Kumar Jha ***@***.***> wrote:
- Version 1.30 is no more supported
- Update extensions accordingly
I'll use the following procedure once the PR is approved to update on prod.
- Take the latest backup of the server and store it locally.
- git pull and docker-compose build
- docker-compose down
- docker volume rm <mediawiki-volume
- docker-compose exec php /srv/mediawiki/maintenance/update.php
- docker-compose up --build -d
- ./script/restore-from-backup.sh <path to sql file>
@icyflame <https://github.com/icyflame> Please have a thorough look.
References:
- https://www.mediawiki.org/wiki/Manual:Upgrading
------------------------------
You can view, comment on, or merge this pull request online at:
#53
Commit Summary
- Update mediawiki to 1.32.2
File Changes
- *M* mediawiki/Dockerfile
<https://github.com/metakgp/metakgp-wiki/pull/53/files#diff-0> (6)
- *M* mediawiki/install_extensions.sh
<https://github.com/metakgp/metakgp-wiki/pull/53/files#diff-1> (2)
Patch Links:
- https://github.com/metakgp/metakgp-wiki/pull/53.patch
- https://github.com/metakgp/metakgp-wiki/pull/53.diff
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#53?email_source=notifications&email_token=AAJBT7ZNCMSNVP5IOXMURBDP2TLRVA5CNFSM4HYO47M2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GZWDY3A>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJBT72BRMACPD3SGDF4URDP2TLRVANCNFSM4HYO47MQ>
.
|
I've updated the instructions; please have a look. |
icyflame
reviewed
Jun 16, 2019
There was a problem hiding this comment.
Good work, @thealphadollar 👍
- Dockerfile changes look good ✔️
- Procedure described in the PR description looks good ✔️
- Test suite failed (after restart) here ❌
- Trying to build the docker images locally also threw the same error as the test suite:
$ docker-compose build
...
...
+ mv MultimediaViewer /srv/mediawiki/extensions/
mv: cannot move 'MultimediaViewer' to '/srv/mediawiki/extensions/MultimediaViewer': Directory not empty
ERROR: Service 'mediawiki' failed to build: The command '/bin/sh -c /tmp/install_extensions.sh' returned a non-zero code: 1We need to investigate and fix this.
|
Looks like MultimediaViewer might be bundled with 1.32, in that case we
don't need to install it separately.
…On Sun, 16 Jun 2019 at 09:15, Siddharth Kannan ***@***.***> wrote:
***@***.**** requested changes on this pull request.
We need to fix this error
<https://travis-ci.org/metakgp/metakgp-wiki/jobs/546100371#L725>.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#53?email_source=notifications&email_token=AAJBT7YWOOSTGJKKAOSJ753P2XZB5A5CNFSM4HYO47M2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3VBDZI#pullrequestreview-250221029>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJBT7ZU2FB5EAHTEDL4N3TP2XZB5ANCNFSM4HYO47MQ>
.
|
This can be found as a notice on MultimediaViewer's page. I'll remove it from downloads. Everything else remains the same. |
- It leads to a `mv` error since it comes preloaded with version >=`1.31` - Removing it from the extension download script removes the error
|
@icyflame @amrav I've updated the PR; have a look please. I've updated lua path as well since it has been changed.
Reference: https://www.mediawiki.org/wiki/Extension:Scribunto#Bundled_binaries |
- The path has been updated as per the recent version of the extension. - https://www.mediawiki.org/wiki/Extension:Scribunto#Lua_errors_in_Scribunto_files
amrav
approved these changes
Jun 16, 2019
icyflame
approved these changes
Jun 21, 2019
- The commands in the RUNBOOK.md are not uptodate. - `docker-compose` requires all the docker file paths to be able to run properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll use the following procedure once the PR is approved to update on prod.
git pullanddocker-compose builddocker-compose downdocker volume rm <mediawiki-volumedocker-compose -f docker-compose.yml -f docker-compose.override.yml -f docker-compose.prod.yml up --build -ddocker-compose exec php /srv/mediawiki/maintenance/update.php@icyflame Please have a thorough look.
References: