Replace cxxfilt with itanium_demangler #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes need for libc, allowing metal-serial to run on windows Closes issue metal-ci#3
|
Failed to build as itanium_demangler requires setuptools, which isn't installed yet. Think this is fixable by putting setuptools first in requirements.txt, will try. |
|
Well that didn't work either, beats me! |
|
Thanks I will check. |
requirements.txt
Outdated
| @@ -1,6 +1,6 @@ | |||
| argparse~=1.4.0 | |||
| pcpp~=1.21 | |||
| pyelftools~=0.26 | |||
| cxxfilt~=0.2.1 | |||
| itanium_demangler~=1.0 | |||
| twine~=3.1.1 | |||
| setuptools~=39.0.1 | |||
There was a problem hiding this comment.
Suggested change
| setuptools~=39.0.1 |
|
Thanks for fixing that, I missed the typo in python3-setuptools. |
|
Looks, good to me, waited for the test to finish & forgot to hit merge ;). |
|
Should be release on pip shortly with https://github.com/metal-ci/test/releases/tag/v0.2.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes need for libc, allowing metal-serial to run on windows
Closes issue #3