Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial encryption support #32

Closed
wants to merge 10 commits into from
Closed

Initial encryption support #32

wants to merge 10 commits into from

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Oct 3, 2020

closes #31

Adds encryption with aes from golang stdlib, only enabled if encryption key is given. Actually all 3 backup providers supported.

TODO: tests

@mwennrich
Copy link
Contributor

Why not placing encryption generic in backup.go after compression, before uploading?

@majst01
Copy link
Contributor Author

majst01 commented Oct 3, 2020

good point, wait a second

@majst01
Copy link
Contributor Author

majst01 commented Oct 3, 2020

unsure if we should use a cli which is available on linux instead of our homegrown implementation. At least we should implement a possibility into this application to decrypt downloaded backups locally, for debugging and testing purpose.

WDYT ?

@mwennrich
Copy link
Contributor

Maybe a "no database" mode, where the files get downloaded, decrypted, and decompressed?

@majst01
Copy link
Contributor Author

majst01 commented Oct 5, 2020

Yes, added a --download-only flag to the restore command.

@majst01
Copy link
Contributor Author

majst01 commented Nov 12, 2020

Another option would be to implement support for SSE-C, or SSE-S3 as described https://docs.aws.amazon.com/AmazonS3/latest/dev/ServerSideEncryptionCustomerKeys.html

Ceph RGW does support this as well: https://docs.ceph.com/en/latest/radosgw/encryption/#customer-provided-keys

@majst01
Copy link
Contributor Author

majst01 commented Oct 24, 2024

implemented with #97

@majst01 majst01 closed this Oct 24, 2024
@majst01 majst01 deleted the encryption branch October 24, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optionally support encryption
2 participants