Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile network configuration #75

Merged
merged 11 commits into from
Apr 7, 2021
Merged

Conversation

mwindower
Copy link
Contributor

reconcile network configuration with the information given in the firewall spec by the gardener-extension-provider-metal

@mwindower
Copy link
Contributor Author

Successfully tested on a cluster in the test environment. With a release of the firewall-controller we could add this to the gepm.

@mwindower mwindower marked this pull request as ready for review April 1, 2021 13:02
Copy link
Contributor

@majst01 majst01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we do not have the possiblilty to record an event if networks changed. The whole changed logic is inside the Apply method, which does not return an indicator if changes where applied.
We will also create new frr configuration for very old frr versions which might be untested with this frr.conf.tpl.

@mwindower
Copy link
Contributor Author

some notes here:

  • changed the signature of the apply method of metal-networker
  • record events about network reconcilation
  • we check all flavors of FRR configurations we generate in combination with FRR 7.3 and 7.5 and Ubuntu+Debian - the check for FRR 7.2 is not sucessful (but only because of the machine template that uses a newer instruction ... but this is irrelevant for the firewall-controller)

@mwindower mwindower merged commit b3a04bb into master Apr 7, 2021
@mwindower mwindower deleted the reconcile-network-settings branch April 7, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants