-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconcile network configuration #75
Conversation
Successfully tested on a cluster in the test environment. With a release of the firewall-controller we could add this to the gepm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but we do not have the possiblilty to record an event if networks changed. The whole changed logic is inside the Apply method, which does not return an indicator if changes where applied.
We will also create new frr configuration for very old frr versions which might be untested with this frr.conf.tpl.
some notes here:
|
reconcile network configuration with the information given in the firewall spec by the gardener-extension-provider-metal