Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use shared auditing from metal-lib #425

Merged
merged 7 commits into from
Mar 31, 2023

Conversation

vknabel
Copy link
Contributor

@vknabel vknabel commented Mar 2, 2023

Based upon metal-stack/metal-lib#73

Removes the internal auditing package in favor of the new package from metal-lib.
Implements https://github.com/metal-stack-cloud/docs/issues/95 for metal-stack.

Part of a group of PRs:

@vknabel vknabel requested a review from a team as a code owner March 2, 2023 09:05
@vknabel vknabel requested a review from majst01 March 2, 2023 09:05
@vknabel vknabel changed the title feat: use shared auditing from metal-lib DRAFT: use shared auditing from metal-lib Mar 2, 2023
@Gerrit91 Gerrit91 marked this pull request as draft March 2, 2023 13:17
@Gerrit91 Gerrit91 changed the title DRAFT: use shared auditing from metal-lib use shared auditing from metal-lib Mar 2, 2023
@vknabel
Copy link
Contributor Author

vknabel commented Mar 7, 2023

@Gerrit91 do you have an idea why the integration tests failed?
https://github.com/metal-stack/metal-api/actions/runs/4354209132/jobs/7609232493#step:4:211

From my perspective this should be unrelated.

go.mod Outdated Show resolved Hide resolved
@vknabel vknabel marked this pull request as ready for review March 8, 2023 09:44
Makefile Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@majst01 majst01 merged commit 307c61f into master Mar 31, 2023
@majst01 majst01 deleted the feature/shared-auditing-in-metal-lib branch March 31, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants