Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metal-core version to switch OS details #450

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Jul 4, 2023

This enables us to show the metal-core version in metalctl switch ls -o wide as well

Related:

@majst01 majst01 marked this pull request as ready for review July 4, 2023 12:39
@majst01 majst01 requested a review from a team as a code owner July 4, 2023 12:39
@majst01 majst01 requested a review from Gerrit91 July 4, 2023 12:39
Copy link
Contributor

@Gerrit91 Gerrit91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, only the choice to put the version beneath SwitchOS feels a bit weird. Not a deal breaker.

@majst01
Copy link
Contributor Author

majst01 commented Jul 5, 2023

Perfect, only the choice to put the version beneath SwitchOS feels a bit weird. Not a deal breaker.

I was also thinking about that, but it is basically a part of the SwitchOS.

@majst01 majst01 merged commit 7974647 into master Jul 5, 2023
2 checks passed
@majst01 majst01 deleted the add-metal-core-version-to-switch branch July 5, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants