Report powersupply status #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerrit91
reviewed
Oct 2, 2024
| @@ -29,6 +29,7 @@ func (i *ReportItem) EnrichWithBMCDetails(ipmiPort int, ipmiUser, ipmiPassword s | |||
| } | |||
| } else { | |||
| i.Log.Warn("could not retrieve bmc details of device", "mac", i.Mac, "ip", i.Ip, "err", err) | |||
| return err | |||
There was a problem hiding this comment.
So, what is the implication of this? When skipping the error the reporting just sent part of the data and now it does not return the machine, I assume?
There was a problem hiding this comment.
The the calling errgroup is now vanishing the error :-) so no machine should be skipped if i am right
mwennrich
approved these changes
Oct 2, 2024
Gerrit91
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Closes #69
Depends on:
Additional Description
Allow metal-bmc to report the state and health of the powersupplies of a machine.