Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcom SONiC Support #112

Draft
wants to merge 40 commits into
base: master
Choose a base branch
from
Draft

Broadcom SONiC Support #112

wants to merge 40 commits into from

Conversation

robertvolkmann
Copy link
Contributor

No description provided.

@robertvolkmann
Copy link
Contributor Author

robertvolkmann commented Nov 7, 2023

metal-hammer fails to register machine:

2023-11-07T17:50:33.026Z	debug	lldp	{"detectedNeighbor": "Name:eqx-mu4-r01leaf02 Desc:SONiC Software Version: SONiC.Edgecore-SONiC_20230505_014148_ec202111_386 - HwSku: Accton-AS7726-32X - Distribution: Debian 11.7 - Kernel: 5.10.0-8-2-amd64 Chassis:Mac:e0:01:a6:e3:14:3c Port:Local:Eth8/1(Port8)"}
2023-11-07T17:50:33.026Z	info	lldp	{"neighbors": {"eth3":[{"Name":"eqx-mu4-r01leaf02","Description":"SONiC Software Version: SONiC.Edgecore-SONiC_20230505_014148_ec202111_386 - HwSku: Accton-AS7726-32X - Distribution: Debian 11.7 - Kernel: 5.10.0-8-2-amd64","Interface":"eth3","Chassis":{"Type":"Mac","Value":"e0:01:a6:e3:14:3c"},"Port":{"Type":"Local","Value":"Eth8/1(Port8)"}}]}}
2023-11-07T17:50:33.026Z	debug	lldp	{"detectedNeighbor": "Name:eqx-mu4-r01leaf01 Desc:SONiC Software Version: SONiC.4.1.1-Enterprise_Base - HwSku: Accton-AS7726-32X - Distribution: Debian 10.13 - Kernel: 5.10.0-8-2-amd64 Chassis:Mac:e0:01:a6:e3:2b:3c Port:Local:Ethernet28"}
2023-11-07T17:50:33.026Z	info	lldp	{"neighbors": {"eth2":[{"Name":"eqx-mu4-r01leaf01","Description":"SONiC Software Version: SONiC.4.1.1-Enterprise_Base - HwSku: Accton-AS7726-32X - Distribution: Debian 10.13 - Kernel: 5.10.0-8-2-amd64","Interface":"eth2","Chassis":{"Type":"Mac","Value":"e0:01:a6:e3:2b:3c"},"Port":{"Type":"Local","Value":"Ethernet28"}}],"eth3":[{"Name":"eqx-mu4-r01leaf02","Description":"SONiC Software Version: SONiC.Edgecore-SONiC_20230505_014148_ec202111_386 - HwSku: Accton-AS7726-32X - Distribution: Debian 11.7 - Kernel: 5.10.0-8-2-amd64","Interface":"eth3","Chassis":{"Type":"Mac","Value":"e0:01:a6:e3:14:3c"},"Port":{"Type":"Local","Value":"Eth8/1(Port8)"}}]}}
2023-11-07T17:50:33.461Z	info	all lldp pdu's received	{"interface": "eth0"}
2023-11-07T17:50:33.461Z	info	register found neighbor for	{"nic": "eth0", "neighbors": null}
2023-11-07T17:50:33.461Z	info	register search neighbor for	{"nic": "eth1"}
2023-11-07T17:50:33.461Z	info	all lldp pdu's received	{"interface": "eth1"}
2023-11-07T17:50:33.461Z	info	register found neighbor for	{"nic": "eth1", "neighbors": null}
2023-11-07T17:50:33.461Z	info	register search neighbor for	{"nic": "eth2"}
2023-11-07T17:50:33.461Z	info	all lldp pdu's received	{"interface": "eth2"}
2023-11-07T17:50:33.461Z	info	register add neighbor	{"nic": "eth2", "identifier": "Ethernet28"}
2023-11-07T17:50:33.461Z	info	register found neighbor for	{"nic": "eth2", "neighbors": [{"mac":"Ethernet28","name":"eth2","hostname":"eqx-mu4-r01leaf01","identifier":"Ethernet28"}]}
2023-11-07T17:50:33.461Z	info	register search neighbor for	{"nic": "eth3"}
2023-11-07T17:50:33.461Z	info	all lldp pdu's received	{"interface": "eth3"}
2023-11-07T17:50:33.461Z	info	register add neighbor	{"nic": "eth3", "identifier": "Eth8/1(Port8)"}
2023-11-07T17:50:33.461Z	info	register found neighbor for	{"nic": "eth3", "neighbors": [{"mac":"Eth8/1(Port8)","name":"eth3","hostname":"eqx-mu4-r01leaf02","identifier":"Eth8/1(Port8)"}]}
2023-11-07T17:50:33.461Z	info	register search neighbor for	{"nic": "lo"}
2023-11-07T17:50:33.461Z	info	all lldp pdu's received	{"interface": "lo"}
2023-11-07T17:50:33.461Z	info	register found neighbor for	{"nic": "lo", "neighbors": null}
2023-11-07T17:50:33.485Z	info	ipmi details from bmc
2023-11-07T17:50:33.820Z	info	register	{"request": "uuid:\"07fbea00-6bc6-11ed-8000-3cecefa83408\"  hardware:{memory:34091302912  cpu_cores:8  disks:{name:\"/dev/nvme0n1\"  size:960197124096}  nics:{mac:\"3c:ec:ef:a8:34:08\"  name:\"eth0\"}  nics:{mac:\"3c:ec:ef:a8:34:09\"  name:\"eth1\"}  nics:{mac:\"50:7c:6f:3e:8f:26\"  name:\"eth2\"  neighbors:{mac:\"Ethernet28\"  name:\"eth2\"  hostname:\"eqx-mu4-r01leaf01\"  identifier:\"Ethernet28\"}}  nics:{mac:\"50:7c:6f:3e:8f:27\"  name:\"eth3\"  neighbors:{mac:\"Eth8/1(Port8)\"  name:\"eth3\"  hostname:\"eqx-mu4-r01leaf02\"  identifier:\"Eth8/1(Port8)\"}}  nics:{mac:\"00:00:00:00:00:00\"  name:\"lo\"}}  bios:{version:\"1.2c\"  vendor:\"American Megatrends Inc.\"  date:\"07/24/2020\"}  ipmi:{address:\"10.1.1.33:623\"  mac:\"3c:ec:ef:da:b1:c3\"  user:\"metal\"  password:\"j1TO9FNAe3\"  interface:\"lanplus\"  fru:{chassis_part_number:\"CSE-938NH-R1K68BP\"  chassis_part_serial:\"C9380AK34PA0099\"  board_mfg:\"Supermicro\"  board_mfg_serial:\"\"  board_part_number:\"X11SDD-8C-F\"  product_manufacturer:\"sysGen www.sysgen.de\"  product_part_number:\"SYS-5039MD8-H8TNR\"  product_serial:\"E340538X2C02843H\"}  bmc_version:\"3.74\"}  metal_hammer_version:\"v0.11.5\""}
2023-11-07T17:50:33.915Z	error	metal-hammer failed	{"rebooting in": 5, "error": "register unable to register machine:&v1.BootServiceRegisterRequest{state:impl.MessageState{NoUnkeyedLiterals:pragma.NoUnkeyedLiterals{}, DoNotCompare:pragma.DoNotCompare{}, DoNotCopy:pragma.DoNotCopy{}, atomicMessageInfo:(*impl.MessageInfo)(0xc000214520)}, sizeCache:563, unknownFields:[]uint8(nil), Uuid:\"07fbea00-6bc6-11ed-8000-3cecefa83408\", Hardware:(*v1.MachineHardware)(0xc00070a0e0), Bios:(*v1.MachineBIOS)(0xc0007389c0), Ipmi:(*v1.MachineIPMI)(0xc00020a3c0), Tags:[]string(nil), MetalHammerVersion:\"v0.11.5\"} rpc error: code = Internal desc = machine 07fbea00-6bc6-11ed-8000-3cecefa83408 is not connected to exactly two switches, found connections to 1 switches"}

@robertvolkmann
Copy link
Contributor Author

I adjusted the LLDP configuration of the Broadcom switch to report the same port identifier as an Edgecore switch but metal-api is still complaining:

2023-11-08T07:35:50.426Z	info	register	{"request": "uuid:\"07fbea00-6bc6-11ed-8000-3cecefa83408\"  hardware:{memory:34091302912  cpu_cores:8  disks:{name:\"/dev/nvme0n1\"  size:960197124096}  nics:{mac:\"3c:ec:ef:a8:34:08\"  name:\"eth0\"}  nics:{mac:\"3c:ec:ef:a8:34:09\"  name:\"eth1\"}  nics:{mac:\"50:7c:6f:3e:8f:26\"  name:\"eth2\"  neighbors:{mac:\"Eth8/1(Port8)\"  name:\"eth2\"  hostname:\"eqx-mu4-r01leaf01\"  identifier:\"Eth8/1(Port8)\"}}  nics:{mac:\"50:7c:6f:3e:8f:27\"  name:\"eth3\"  neighbors:{mac:\"Eth8/1(Port8)\"  name:\"eth3\"  hostname:\"eqx-mu4-r01leaf02\"  identifier:\"Eth8/1(Port8)\"}}  nics:{mac:\"00:00:00:00:00:00\"  name:\"lo\"}}  bios:{version:\"1.2c\"  vendor:\"American Megatrends Inc.\"  date:\"07/24/2020\"}  ipmi:{address:\"10.1.1.33:623\"  mac:\"3c:ec:ef:da:b1:c3\"  user:\"metal\"  password:\"RV8b3XxWL9\"  interface:\"lanplus\"  fru:{chassis_part_number:\"CSE-938NH-R1K68BP\"  chassis_part_serial:\"C9380AK34PA0099\"  board_mfg:\"Supermicro\"  board_mfg_serial:\"\"  board_part_number:\"X11SDD-8C-F\"  product_manufacturer:\"sysGen www.sysgen.de\"  product_part_number:\"SYS-5039MD8-H8TNR\"  product_serial:\"E340538X2C02843H\"}  bmc_version:\"3.74\"}  metal_hammer_version:\"v0.11.5\""}
2023-11-08T07:35:50.482Z	error	metal-hammer failed	{"rebooting in": 5, "error": "register unable to register machine:&v1.BootServiceRegisterRequest{state:impl.MessageState{NoUnkeyedLiterals:pragma.NoUnkeyedLiterals{}, DoNotCompare:pragma.DoNotCompare{}, DoNotCopy:pragma.DoNotCopy{}, atomicMessageInfo:(*impl.MessageInfo)(0xc000214520)}, sizeCache:569, unknownFields:[]uint8(nil), Uuid:\"07fbea00-6bc6-11ed-8000-3cecefa83408\", Hardware:(*v1.MachineHardware)(0xc0000fa700), Bios:(*v1.MachineBIOS)(0xc000242420), Ipmi:(*v1.MachineIPMI)(0xc000338960), Tags:[]string(nil), MetalHammerVersion:\"v0.11.5\"} rpc error: code = Internal desc = machine 07fbea00-6bc6-11ed-8000-3cecefa83408 is not connected to exactly two switches, found connections to 1 switches"}
2023-11-08T07:35:50.482Z	info	event	{"event": "Crashed", "message": "register unable to register machine:&v1.BootServiceRegisterRequest{state:impl.MessageState{NoUnkeyedLiterals:pragma.NoUnkeyedLiterals{}, DoNotCompare:pragma.DoNotCompare{}, DoNotCopy:pragma.DoNotCopy{}, atomicMessageInfo:(*impl.MessageInfo)(0xc000214520)}, sizeCache:569, unknownFields:[]uint8(nil), Uuid:\"07fbea00-6bc6-11ed-8000-3cecefa83408\", Hardware:(*v1.MachineHardware)(0xc0000fa700), Bios:(*v1.MachineBIOS)(0xc000242420), Ipmi:(*v1.MachineIPMI)(0xc000338960), Tags:[]string(nil), MetalHammerVersion:\"v0.11.5\"} rpc error: code = Internal desc = machine 07fbea00-6bc6-11ed-8000-3cecefa83408 is not connected to exactly two switches, found connections to 1 switches"}

@robertvolkmann robertvolkmann marked this pull request as ready for review November 9, 2023 08:45
@robertvolkmann robertvolkmann requested a review from a team as a code owner November 9, 2023 08:45
@mwindower
Copy link
Contributor

Are those changes compatible with EC-SONiC?
I'm especially curious about the admin_up attribute of VLANs because that is not existing in EC-SONiC.

@robertvolkmann robertvolkmann marked this pull request as draft December 12, 2023 11:56
robertvolkmann and others added 16 commits January 11, 2024 13:32
# Conflicts:
#	cmd/internal/switcher/sonic/redis/applier.go
# Conflicts:
#	cmd/config.go
#	cmd/internal/core/core.go
#	cmd/internal/core/reconfigure-switch.go
#	cmd/internal/switcher/sonic/redis/applier.go
#	cmd/internal/switcher/templates/template_test.go
#	cmd/internal/switcher/templates/test_down_interfaces/conf_with_downports.yaml
#	cmd/internal/switcher/templates/test_down_interfaces/interfaces_with_downports
#	cmd/internal/switcher/types/types.go
#	cmd/server.go
#	go.mod
#	go.sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants