Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the additional route map cidr default value #134

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Nov 13, 2024

Description

This feature is now calculated in the metal-api and can be configured in a tenant-super-network.

Closes #131

TODO:

  • Fix Tests
  • adopt metal-roles, is actually not configurable in metal-roles.

@majst01 majst01 marked this pull request as ready for review November 13, 2024 08:11
@majst01 majst01 requested a review from a team as a code owner November 13, 2024 08:11
Copy link
Contributor

@robertvolkmann robertvolkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mind metal-roles.

cmd/internal/core/reconfigure-switch_test.go Outdated Show resolved Hide resolved
@majst01 majst01 merged commit d8c102d into master Nov 25, 2024
1 check passed
@majst01 majst01 deleted the remove-additional-route-map-cidrs branch November 25, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove AdditionalRouteMapCidrs Default value
2 participants