-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render SONiC config_db.json
directly without using sonic-cfggen
#211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize persistence strategy by selectively storing essential segments, such as breakout and port configurations, instead of the entire running configuration. This mitigates undesired configurations, particularly those arising from metal-core.
This was referenced Sep 5, 2023
Closed
This key should be contained as otherwise validations would fail.
robertvolkmann
force-pushed
the
refine-sonic-config-persistence
branch
from
September 8, 2023 11:59
4058429
to
e233af9
Compare
Gerrit91
approved these changes
Sep 22, 2023
Gerrit91
changed the title
Optimize /etc/sonic/config_db.json Persistence by Selectively Storing Essential Configurations
Render SONiC Sep 22, 2023
config_db.json
directly without using sonic-cfggen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, our method involved persisting the entirety of the running configuration into
/etc/sonic/config_db.json
by runningconfig save
in a task. This approach led to undesired configurations being retained, especially noticeable after a switch reboot. A key example of such undesired configurations arises frommetal-core
.To refine this, we have now transitioned to a selective persistence strategy. Instead of saving the entire running configuration, only crucial segments are extracted and stored. Specifically, these segments relate to the breakout and port configuration. This approach ensures a cleaner and more focused
/etc/sonic/config_db.json
, mitigating the presence of unintended configurations.