-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to changes needed for gardener-node-agent
#33
base: master
Are you sure you want to change the base?
Conversation
Hi @rfranzke This is awsome, thanks so much, will take a while til we can test this. |
Why does the build fail? Running |
It says NewActuator is undefined ? |
I see this 😄 But all occurrences of |
I check |
I updated master with this PR: #34 which compiled nicely, please pull master and it should compile your PR again. Guess its because the newer linter does not like go-1.20 ?? |
/hold |
/unhold /cc @Gerrit91 @majst01 @oliver-goetz |
Will do, thanks a lot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice PR 😄
/ok-to-build |
The controller cannot be deployed because the installation helm chart is now broken. 😅
|
Sorry for the delay, this should be fixed now. I've also rebased to |
Please note, there is one more addition:
|
Later, when this PR is merged, and then even later, after you upgraded to |
In the future, the `pkg/controller/operatingsystemconfig/generator` package can be deleted entirely
- no longer use `oscommon` package - prepare for new OSC contract when `UseGardenerNodeAgent` feature gate is enabled
- no longer depend on `oscommon` package
It is `true` by default (even when `UseGardenerNodeAgent` is not provided via `.Values.gardener.gardenlet.featureGates` in the Helm chart values).
How to categorize this PR?
/area os
/kind enhancement
What this PR does / why we need it:
This PR adapts this extension to changes needed for
gardener-node-agent
, see gardener/gardener#8647 for more information.Which issue(s) this PR fixes:
Part of gardener/gardener#8023
Special notes for your reviewer:
Kindly use the dedicated commits for an easier review process.
/cc @oliver-goetz @majst01 @Gerrit91
Release note: