go-1.23 and satisfy linter warnings #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same applies for |
|
The error was a race condition within the tests if a couple of additional milliseconds passed. As a barrier I subtracted some milliseconds from the awaited time period. |
vknabel
previously approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Fine from my point of view.
@mwennrich you have the honor to apply the final review and merge as I contributed to the tests.
Gerrit91
reviewed
Oct 8, 2024
Gerrit91
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove home grown crypto
TODO:
@vknabel sometimes TestMultiIssuerCache_retryFailing is failing ? Please have a look during my vacation