Set a timeout for DB pings, and log timing stats for readiness check failures #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottGarman
force-pushed
the
debug-readiness
branch
from
b458ac2
to
f96650e
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
- Coverage 72.72% 71.47% -1.25%
==========================================
Files 10 10
Lines 792 1143 +351
==========================================
+ Hits 576 817 +241
- Misses 157 267 +110
Partials 59 59
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
nshalman
reviewed
Oct 4, 2023
ScottGarman
force-pushed
the
debug-readiness
branch
from
f96650e
to
1d78aba
Compare
ScottGarman
force-pushed
the
debug-readiness
branch
from
1d78aba
to
b602825
Compare
This reverts commit 7810bc0.
nshalman
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.